Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85754?usp=email )
Change subject: mb/google/fatcat/var/fatcat: Modify interrupt GPIO for LPSS I2C touchpad ......................................................................
mb/google/fatcat/var/fatcat: Modify interrupt GPIO for LPSS I2C touchpad
Change the interrupt GPIO for LPSS I2C based touchpad from GPP_F18 to GPP_A13 to match the current fatcat configuration.
BUG=b:376019577 TEST=Able to verify the touchpad functionality using 'THAT' touchpad module.
Change-Id: I37a9d3aae67883f9eb4f47d76b4f48ac6ebb6d16 Signed-off-by: Pranava Y N pranavayn@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85754 Reviewed-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c M src/mainboard/google/fatcat/variants/fatcat/gpio.c M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb 3 files changed, 5 insertions(+), 7 deletions(-)
Approvals: Kapil Porwal: Looks good to me, approved Dtrain Hsu: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c index 728d0f9..6ac0755 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c +++ b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c @@ -439,8 +439,8 @@ PAD_CFG_NF(GPP_F12, NONE, DEEP, NF8), /* GPP_F13: THC_I2C1_SDA_TCH_PAD */ PAD_CFG_NF(GPP_F13, NONE, DEEP, NF8), - /* GPP_F18: TCH_PAD_INT_N */ - PAD_CFG_GPI_APIC(GPP_F18, NONE, PLTRST, EDGE_SINGLE, INVERT), + /* GPP_A13: TCH_PAD_INT_N */ + PAD_CFG_GPI_IRQ_WAKE(GPP_A13, NONE, PWROK, LEVEL, INVERT), };
static const struct pad_config touchpad_i2c_disable_pads[] = { @@ -448,8 +448,8 @@ PAD_NC(GPP_F12, NONE), /* GPP_F13: THC_I2C1_SDA_TCH_PAD */ PAD_NC(GPP_F13, NONE), - /* GPP_F18: TCH_PAD_INT_N */ - PAD_NC(GPP_F18, NONE), + /* GPP_A13: TCH_PAD_INT_N */ + PAD_NC(GPP_A13, NONE), };
static const struct pad_config ish_disable_pads[] = { diff --git a/src/mainboard/google/fatcat/variants/fatcat/gpio.c b/src/mainboard/google/fatcat/variants/fatcat/gpio.c index a5a1be1..881c5c7 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/gpio.c +++ b/src/mainboard/google/fatcat/variants/fatcat/gpio.c @@ -36,8 +36,6 @@ PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* GPP_A12: WIFI_WAKE_N */ PAD_CFG_GPI_SCI_LOW(GPP_A12, NONE, DEEP, LEVEL), - /* GPP_A13: Not used */ - PAD_NC(GPP_A13, NONE), /* GPP_A15: GPP_A15_DNX_FORCE_RELOAD */ PAD_CFG_NF(GPP_A15, NONE, DEEP, NF1), /* GPP_A16: BT_RF_KILL_N */ diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index 60fb95f..693d6cf 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -756,7 +756,7 @@ chip drivers/i2c/hid register "generic.hid" = ""HFW68H"" register "generic.desc" = ""Hynitron TOUCHPAD"" - register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F18_IRQ)" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_A13_IRQ)" register "generic.uid" = "5" register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20"