Attention is currently required from: Caveh Jalali, Eric Lai, Alexander Couzens, Felix Held, Boris Mittelberg.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70846 )
Change subject: tree: Replace Or(a,b,c) with ASL 2.0 syntax ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/aopen/dxplplusu/acpi/power.asl:
https://review.coreboot.org/c/coreboot/+/70846/comment/d3fe026e_50cab6cd PS3, Line 53: 9
i would prefer these constants to retain their 0x0 form.
Done
File src/mainboard/aopen/dxplplusu/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/70846/comment/43fd2e25_21a13a8a PS3, Line 135: 1
another case where 0x01 would make more sense.
Why does it make more sense? I can understand that for all numbers >= 0xa but not for the numbers below that. 0x01 is more complicated to read than just 1. I don't see an advantage for 0x01 over 1.
File src/soc/intel/baytrail/acpi/lpe.asl:
https://review.coreboot.org/c/coreboot/+/70846/comment/95e8cb39_001ea27f PS3, Line 90: 3
0x03?
Done
File src/soc/intel/baytrail/acpi/lpss.asl:
https://review.coreboot.org/c/coreboot/+/70846/comment/683735ac_6d6649cc PS3, Line 115: 3
0x03?
Done