CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43963 )
Change subject: mb/google/asurada: Add new MT8192 mainboard "Asurada"
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43963/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43963/6//COMMIT_MSG@7
PS6, Line 7: Add a stub implementation of Asurada mainboard
mb/google/asurada: new MT8192 mainboard "Asurada" […]
Done
https://review.coreboot.org/c/coreboot/+/43963/6/src/mainboard/google/asurad...
File src/mainboard/google/asurada/chromeos.c:
https://review.coreboot.org/c/coreboot/+/43963/6/src/mainboard/google/asurad...
PS6, Line 10: }
can you add the placeholder for 'boardid. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43963
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c8bc8a4bba40d1b511823e09945be52198b247
Gerrit-Change-Number: 43963
Gerrit-PatchSet: 7
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 03:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment