Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31868 )
Change subject: mb/google/hatch: fix RCompResistor[0] value ......................................................................
mb/google/hatch: fix RCompResistor[0] value
From doc#573387 CML System Memory DQ DQS Rcomp Mapping Information User Guide, RCompResistor[0] should be 121.
BUG=b:122959294 BRANCH=None TEST=emerge coreboot and make sure boots up
Change-Id: If69e7fb41e79d88d21b0e50fb65107a1686d696a Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31868 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/memory.c b/src/mainboard/google/hatch/variants/baseboard/memory.c index 6ca98e4..b6a6615 100644 --- a/src/mainboard/google/hatch/variants/baseboard/memory.c +++ b/src/mainboard/google/hatch/variants/baseboard/memory.c @@ -30,8 +30,8 @@ .dqs_map[DDR_CH0] = { 0, 1, 4, 5, 2, 3, 6, 7 }, .dqs_map[DDR_CH1] = { 0, 1, 4, 5, 2, 3, 6, 7 },
- /* Baseboard uses 120, 81 and 100 rcomp resistors */ - .rcomp_resistor = { 120, 81, 100 }, + /* Baseboard uses 121, 81 and 100 rcomp resistors */ + .rcomp_resistor = { 121, 81, 100 },
/* Baseboard Rcomp target values */ .rcomp_targets = { 100, 40, 20, 20, 26 },