Attention is currently required from: Furquan Shaikh, Jack Rosenthal. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 )
Change subject: elogtool: add "clear" command ......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4: Thanks. fixed!
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/1b730845_8c5129e2 PS3, Line 825:
indent to (
Done
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/6015d14b_91cb77d3 PS2, Line 166: NULL
hmm ... good point ... separate inputs and outputs may be a useful feature, especially for testing.. […]
sg
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/240b386b_081d9961 PS3, Line 200: { : buffer_delete(&buf); : return ret; : }
you can drop the repeated code by using a goto […]
Done