Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31471 )
Change subject: sb/intel/i82371eb/fadt: Fix compilation on x86_64 ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Let's make qemu a clean sample of x86_64 casts and fix rest of the tree to match.
https://review.coreboot.org/#/c/31471/2/src/southbridge/intel/i82371eb/fadt.... File src/southbridge/intel/i82371eb/fadt.c:
https://review.coreboot.org/#/c/31471/2/src/southbridge/intel/i82371eb/fadt.... PS2, Line 50: fadt->dsdt = (uintptr_t)dsdt; We have pretty much the same in mainboard directories. I feel uinptr_t is the correct one to use, but I can see unsigned long elsewhere.
https://review.coreboot.org/#/c/31471/2/src/southbridge/intel/i82371eb/fadt.... PS2, Line 159: fadt->x_dsdt_h = 0; I was going to suggest what you already tried in patchset #1. Once we have some agreement on what to do with -Wshift-xxx we can return to this and probably all similar cases under mainboard/ as well.