Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36614 )
Change subject: soc/intel/common/sa: Remove EBDA dependency
......................................................................
Patch Set 4: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/36614/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36614/3//COMMIT_MSG@7
PS3, Line 7: soc/intel/common/sa: Properly guard the FSP-TOLUM cbmem_top implementation
It's too long, drop "the" and "implementation"? […]
Done
https://review.coreboot.org/c/coreboot/+/36614/3//COMMIT_MSG@9
PS3, Line 9: not needed
not needed anymore
Done
https://review.coreboot.org/c/coreboot/+/36614/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/36614/3/src/soc/intel/common/block/...
PS3, Line 9: initialize
chipset?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb3534b88de4f7b6fc39675a77461265605e56e
Gerrit-Change-Number: 36614
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 10 Nov 2019 15:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment