Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35365 )
Change subject: emulation/qemu-i440fx: use fw_cfg_dma for fw_cfg_read ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35365/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35365/10//COMMIT_MSG@14 PS10, Line 14: TEST=Build and boot using qemu-i440fx.
What options did you use?
Normal build process for the target qemu-i440fx along with some debug messages are only required for the test success/failure detection. I have verified for its successful execution and calling the fw_cfg_dma (read using dma)
https://review.coreboot.org/c/coreboot/+/35365/10/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/35365/10/src/mainboard/emulation/qe... PS10, Line 529:
Add a debug/spew message what values are set?
IMHO, the debug/spew messages are not required here as all parameters are parsed to this function as input. Can be referred to the insb function as well, I think provide printing of parameters to every read command is not good idea.