Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41690 )
Change subject: mb/ocp/deltalake: Config PCH PCIe ports
......................................................................
Patch Set 11: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41690/11/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/chip.h:
https://review.coreboot.org/c/coreboot/+/41690/11/src/soc/intel/xeon_sp/cpx/...
PS11, Line 15: /*Struct for configuring PCH PCIe port*/
nit: spaces around the comment start and end symbols:
/* Struct for configuring PCH PCIe port */
https://review.coreboot.org/c/coreboot/+/41690/11/src/vendorcode/intel/fsp/f...
File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/41690/11/src/vendorcode/intel/fsp/f...
PS11, Line 144: {
add a space
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I189027c403814d68db2b7c5f41fc254a293fe3a1
Gerrit-Change-Number: 41690
Gerrit-PatchSet: 11
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jul 2020 10:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment