Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34765 )
Change subject: kohaku: add TEMP_SENSOR_3 and TEMP_SENSOR_4 to DPTF ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 30: Thermal Sensor 3 Share info on what are these "Thermal Sensor 1/2/3/4" used for on this kohaku variant?
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 31: #define DPTF_TSR2_PASSIVE 65 : #define DPTF_TSR2_CRITICAL 75 Are these initial values ? Is there any plan to tune/modify in coming weeks?
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 62: GT Share more details on this GT throttling as per above comment.