Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43294 )
Change subject: mb/google/dedede: Change HDMI DDC GPIOs to native function
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43294/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/43294/2/src/mainboard/google/dedede...
PS2, Line 225: PAD_CFG_NF(GPP_E16, NONE, DEEP, NF1),
Since this is generic configuration of dedede baseboard, we need to set it if we're planning to use […]
I agree with Marco. We can configure the GPIOs corresponding to DDI2 alone.
As per the schematics both the reference designs don't use DDI0/1. Also the SDA pins in DDI0/1 are used for hardware strapping purposes. So I am not sure if we will use these pins for other purposes in other variants. If we happen to do so, we can always override it in the concerned variant boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If02f062132d7c3b01b07ea9401e81f451df35c3c
Gerrit-Change-Number: 43294
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Kirtika Ruchandani
kirtika@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jul 2020 17:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment