Attention is currently required from: Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58188 )
Change subject: nb/sandybridge:add CBMEM_MEMINFO table when initing RAM ......................................................................
Patch Set 1:
(6 comments)
File src/northbridge/intel/sandybridge/raminit_mrc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130019): https://review.coreboot.org/c/coreboot/+/58188/comment/7c1147bd_c57e27e1 PS1, Line 392: struct memory_info* mem_info; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130019): https://review.coreboot.org/c/coreboot/+/58188/comment/3e4802d1_45af275a PS1, Line 422: memcpy(dimm->serial, // bytes 122-125 in SPD please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130019): https://review.coreboot.org/c/coreboot/+/58188/comment/b334da75_8236466d PS1, Line 428: dimm->mod_id = // bytes 117/118 (LSB/MSB) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130019): https://review.coreboot.org/c/coreboot/+/58188/comment/6f7cfd16_86babe49 PS1, Line 446: memcpy(dimm->serial, // bytes 122-125 in SPD please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130019): https://review.coreboot.org/c/coreboot/+/58188/comment/a14f9a4c_d62b7c20 PS1, Line 452: dimm->mod_id = // bytes 117/118 (LSB/MSB) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130019): https://review.coreboot.org/c/coreboot/+/58188/comment/92b85c81_e60e6923 PS1, Line 452: dimm->mod_id = // bytes 117/118 (LSB/MSB) please, no space before tabs