[coreboot-gerrit] [M] Change in coreboot[main]: sio/nuvoton: Implement a common ramstage ACPI LDN helper

[Keith Hui (Code Review)]

Attention is currently required from: Nico Huber, Paul Menzel.

Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )

Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper
......................................................................

Patch Set 6:

(1 comment)

File src/superio/nuvoton/common/common.c:

https://review.coreboot.org/c/coreboot/+/82632/comment/5297675d_2561705a?usp... :
PS6, Line 79: 	 * Clear case open pin 0 status.
> But how if we clear it on boot? Assuming somebody opened the case, tampered, closed […]

If you refer to the datasheet, that bit is a write-clear - I write a 1 there to clear the status. If the switch trips again, status will be set again, and userspace will know. Handling then will be up to the OS.