Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56971
to review the following change.
Change subject: mb/google/dedede/var/kracko: Configure Acoustic noise mitigation ......................................................................
mb/google/dedede/var/kracko: Configure Acoustic noise mitigation
Enable Acoustic noise mitigation for blipper and set slew rate to 1/8 which is calibrated value for the board.
BUG=None BRANCH=dedede TEST=build firmware and verified by power team
Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Change-Id: I3e7f10a99aa00a00713d930c5a9cc24f17280ab0 --- M src/mainboard/google/dedede/variants/kracko/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/56971/1
diff --git a/src/mainboard/google/dedede/variants/kracko/overridetree.cb b/src/mainboard/google/dedede/variants/kracko/overridetree.cb index 3561898..4335aa0 100644 --- a/src/mainboard/google/dedede/variants/kracko/overridetree.cb +++ b/src/mainboard/google/dedede/variants/kracko/overridetree.cb @@ -58,6 +58,12 @@ }, }"
+ # Enable Acoustic noise mitigation and set slew rate to 1/4 + # Rest of the parameters are 0 by default. + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate" = "SlewRateFastBy8" + register "FastPkgCRampDisable" = "1" + device domain 0 on device pci 14.0 on chip drivers/usb/acpi