Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42688 )
Change subject: soc/amd/common: Use gpio_setbits32() ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42688/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42688/4//COMMIT_MSG@8 PS4, Line 8: commit description could use some elaboration w.r.t. motivation, etc.
https://review.coreboot.org/c/coreboot/+/42688/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42688/4/src/soc/amd/common/block/gp... PS4, Line 103: reg32 |= (ctrl & mask); Why wouldn't this just call __gpio_update32() by passing in ~mask and ctrl (or just ctrl & mask) ? It seem odd to repeat the exact same sequence. tail call optimization should kick in.