[coreboot-gerrit] [XS] Change in coreboot[main]: mb/purism/librem_skl: Prefer include <soc/gpio.h> via <gpio.h>

[Jonathon Hall (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Singer.

Jonathon Hall has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82872?usp=email )

Change subject: mb/purism/librem_skl: Prefer include <soc/gpio.h> via <gpio.h>
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3: 
@[e-mail], we discussed this at the last leadership meeting, consensus is that we don't want to change these inclusions across the board.  Including soc/gpio.h from mainboards is OK.

I don't think the style guide really meant to say that you must include gpio.h instead of soc/gpio.h; it's saying that don't need to include both.  gpio.h has include-what-you-use annotations stating it exports soc/gpio.h, which is consistent with that.

Either way, there was agreement that we could edit the style guide for clarity here, and including soc/gpio.h is fine.