Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42496 )
Change subject: lib: Add ASan support to ramstage on x86 arch
......................................................................
Patch Set 28:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42496/10/src/lib/program.ld
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/42496/10/src/lib/program.ld@131
PS10, Line 131: /8
I run into a linker error with this syntax (GCC 8.3.0, GNU ld (GNU Binutils) 2.30): […]
Some linker configurations take "/" as start of comment :-/
https://review.coreboot.org/c/coreboot/+/42496/19/src/lib/program.ld
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/42496/19/src/lib/program.ld@130
PS19, Line 130: .shadow . : {
: _shadow_size = (_eheap - _data) >> 3;
: . = ALIGN(ARCH_POINTER_ALIGN_SIZE);
: _shadow = .;
: . += _shadow_size;
: . = ALIGN(ARCH_POINTER_ALIGN_SIZE);
: _eshadow = .;
: }
: #endif
How about: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica06bd2be78fcfc79fa888721ed920d4e8248f3b
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 28
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 21 Aug 2020 07:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment