Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Sudheer Amrabadi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot ......................................................................
Patch Set 7:
(4 comments)
File src/soc/qualcomm/sc7280/socinfo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161766): https://review.coreboot.org/c/coreboot/+/68384/comment/ea040d91_4f601e7b PS7, Line 50: for(i = 0; i < ARRAY_SIZE(chipinfolut); i++) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161766): https://review.coreboot.org/c/coreboot/+/68384/comment/572f7f07_6c0c7115 PS7, Line 51: if(chipinfolut[i].jtagid == jtagid) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161766): https://review.coreboot.org/c/coreboot/+/68384/comment/30056f74_3fe8be9f PS7, Line 65: if(ret != -1) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161766): https://review.coreboot.org/c/coreboot/+/68384/comment/bd5df736_1e3a6c15 PS7, Line 79: if(ret != -1) space required before the open parenthesis '('