Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45396 )
Change subject: soc/mediatek/mt8192: Add usb host support ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/Mak... File src/soc/mediatek/mt8192/Makefile.inc:
PS1:
Please remove the execute permission.
Done
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/usb.h:
PS1:
Please remove the execute permission.
Done
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/inc... PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Please add a blank line below.
Done
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/usb... File src/soc/mediatek/mt8192/usb.c:
PS1:
Please remove the execute permission.
Done
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/usb... PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/usb... PS1, Line 16:
Please remove the blank line at the end of the file.
Done
https://review.coreboot.org/c/coreboot/+/45396/2/src/soc/mediatek/mt8192/usb... File src/soc/mediatek/mt8192/usb.c:
https://review.coreboot.org/c/coreboot/+/45396/2/src/soc/mediatek/mt8192/usb... PS2, Line 15: }
adding a line without newline at end of file
Please fix this.