Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61094 )
Change subject: soc/amd/sabrina/chipset.cb: update USB ports ......................................................................
soc/amd/sabrina/chipset.cb: update USB ports
The corresponding mainboard design guide was used as a reference here.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ie61af7dab35b560d2eec1ea62058f3a4dad5cb0f Reviewed-on: https://review.coreboot.org/c/coreboot/+/61094 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jason Glenesk jason.glenesk@gmail.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/amd/chausie/devicetree.cb M src/soc/amd/sabrina/chipset.cb 2 files changed, 13 insertions(+), 39 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/mainboard/amd/chausie/devicetree.cb b/src/mainboard/amd/chausie/devicetree.cb index 98030f7..19815b3 100644 --- a/src/mainboard/amd/chausie/devicetree.cb +++ b/src/mainboard/amd/chausie/devicetree.cb @@ -41,20 +41,11 @@ device ref usb3_port0 on end end chip drivers/usb/acpi - device ref usb3_port1 on end - end - chip drivers/usb/acpi device ref usb2_port0 on end end chip drivers/usb/acpi device ref usb2_port1 on end end - chip drivers/usb/acpi - device ref usb2_port2 on end - end - chip drivers/usb/acpi - device ref usb2_port3 on end - end end end end @@ -62,23 +53,20 @@ chip drivers/usb/acpi device ref xhci_1_root_hub on chip drivers/usb/acpi - device ref usb3_port4 on end + device ref usb3_port2 on end end chip drivers/usb/acpi - device ref usb3_port5 on end + device ref usb3_port3 on end + end + chip drivers/usb/acpi + device ref usb2_port2 on end + end + chip drivers/usb/acpi + device ref usb2_port3 on end end chip drivers/usb/acpi device ref usb2_port4 on end end - chip drivers/usb/acpi - device ref usb2_port5 on end - end - chip drivers/usb/acpi - device ref usb2_port6 on end - end - chip drivers/usb/acpi - device ref usb2_port7 on end - end end end end diff --git a/src/soc/amd/sabrina/chipset.cb b/src/soc/amd/sabrina/chipset.cb index caa78e1..c477a17 100644 --- a/src/soc/amd/sabrina/chipset.cb +++ b/src/soc/amd/sabrina/chipset.cb @@ -1,5 +1,3 @@ -# TODO: Check if this is still correct - chip soc/amd/sabrina device cpu_cluster 0 on end @@ -30,20 +28,11 @@ device usb 3.0 alias usb3_port0 off end end chip drivers/usb/acpi - device usb 3.1 alias usb3_port1 off end - end - chip drivers/usb/acpi device usb 2.0 alias usb2_port0 off end end chip drivers/usb/acpi device usb 2.1 alias usb2_port1 off end end - chip drivers/usb/acpi - device usb 2.2 alias usb2_port2 off end - end - chip drivers/usb/acpi - device usb 2.3 alias usb2_port3 off end - end end end end @@ -52,22 +41,19 @@ register "type" = "UPC_TYPE_HUB" device usb 0.0 alias xhci_1_root_hub off chip drivers/usb/acpi - device usb 3.0 alias usb3_port4 off end + device usb 3.0 alias usb3_port2 off end end chip drivers/usb/acpi - device usb 3.1 alias usb3_port5 off end + device usb 3.1 alias usb3_port3 off end end chip drivers/usb/acpi - device usb 2.0 alias usb2_port4 off end + device usb 2.0 alias usb2_port2 off end end chip drivers/usb/acpi - device usb 2.1 alias usb2_port5 off end + device usb 2.1 alias usb2_port3 off end end chip drivers/usb/acpi - device usb 2.2 alias usb2_port6 off end - end - chip drivers/usb/acpi - device usb 2.3 alias usb2_port7 off end + device usb 2.2 alias usb2_port4 off end end end end