Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43277 )
Change subject: mb/mainboard/dedede: update GPIO table for Boten
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43277/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/43277/1/src/mainboard/google/dedede...
PS1, Line 9: pad_config gpio_table[]
I dont think all the GPIOs are different compared to the baseboard. […]
Please use this CL: https://review.coreboot.org/c/coreboot/+/43279 as a base and provide an override GPIO table for GPIOs whose configuration is different compared to the base GPIO table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43277
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4eafee608f657f8ec5a06caf6e99b08b3330512b
Gerrit-Change-Number: 43277
Gerrit-PatchSet: 1
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jul 2020 05:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment