Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari...
File src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari...
PS2, Line 7: # SCSI-68 port is always terminated
Becaus the lines above are using spaces for indentation as well!? Using TABs just in these two lines […]
Most devicetrees are indented with tabs nowadays. Maybe handle this in a separate commit?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba
Gerrit-Change-Number: 42795
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 12:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment