Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36216 )
Change subject: soc/intel: common,skl,cnl,icl: drop reserved mmio memory size calculation ......................................................................
Uploaded patch set 9: Commit message was updated.
(3 comments)
https://review.coreboot.org/c/coreboot/+/36216/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36216/5//COMMIT_MSG@14 PS5, Line 14: Since this will always be equal to 0
Oh, thanks for pointing this out. There was some misunderstanding because […]
Done
https://review.coreboot.org/c/coreboot/+/36216/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36216/7//COMMIT_MSG@22 PS7, Line 22: change) without adding more weird calculations.
The second point seems to be just noise. And I'm not convinced by […]
Done
https://review.coreboot.org/c/coreboot/+/36216/5/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/36216/5/src/soc/intel/common/block/... PS5, Line 178: mmio_resource(dev, index++, base_k / KiB, size_k / KiB);
I'm not sure it matters too much, but this change implicitly marks the PRMRR, trace, and ptt memory […]
I guess this is answered by Nico on the left, isn't it?