Attention is currently required from: Arthur Heymans, Martin L Roth, Matt DeVillier, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76718?usp=email )
Change subject: Revert "util/amdfwtool: Add some PSP entries to both levels"
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
This is really necessary on Genoa. The array could be updated in a platform dependent manner.
we need to look into how to support genoa, but right now the priority should be to get the current in tree socs working again by reverting the patch that broke them
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/76718/comment/343a8fe5_5c944d3c :
PS1, Line 388: {
it does not
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8042690af2764d6e46fe01287be598091b1a239
Gerrit-Change-Number: 76718
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 01 Aug 2023 14:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment