Attention is currently required from: Abhishek Pandit-Subedi, Keith Short, Paul Menzel, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email )
Change subject: ec/google/chromeec: Stop checking CBI for UCSI
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83252/comment/31651453_360d8053?usp... :
PS1, Line 9: Use only EC_FEATURE_UCSI_PPM to determine whether UCSI is enabled.
Thank you. Please update the commit message, as they have to be self-contained.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83252?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7
Gerrit-Change-Number: 83252
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Pandit-Subedi
abhishekpandit@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Keith Short
keithshort@chromium.org
Gerrit-Attention: Abhishek Pandit-Subedi
abhishekpandit@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 09 Jul 2024 16:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Abhishek Pandit-Subedi
abhishekpandit@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org