Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47381 )
Change subject: drivers/analogix: add MIPI rx flow ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 817: *****
I don't see similar patterns in this file. […]
Done
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 822: anx7625_reg_write
Please handle the return value.
Done
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 827: anx7625_reg_write
Please handle the return value.
Done
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 829: ANXINFO("***** mipi rx, dp tx initial finish.\n");
Same.
Done