Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Felix Held has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83957?usp=email )
Change subject: soc/intel/alderlake: Switch to SOC_INTEL_COMMON_DEBUG_CONSENT
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83957/comment/0439b9bd_2410d194?usp... :
PS2, Line 435: default 0
the default 0 line is probably unneeded, since that's also the default in the basecode kconfig in th […]
i mean it doesn't hurt to keep that one, but would be good if you can have a quick look at this and decide on whether to keep that duplicate default 0 or not; i don't have a too strong opinion on this, so i'd be fine with this just marked as resolved
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83957?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a9c81b72d707f5ed2e1a53c139ee22be0e30068
Gerrit-Change-Number: 83957
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 20 Aug 2024 12:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de