Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG@11
PS5, Line 11:
I think that the default can be changed. […]
The Kconfig defaults preserve the old behaviour and I've noted this in the commit message.
Besides, see CB:41763. The logic was to align Jasperlake with the other platforms, not to disable the feature. However, other platforms have it enabled.
https://review.coreboot.org/c/coreboot/+/42745/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/7//COMMIT_MSG@10
PS7, Line 10: protection
That would be covered as part of the quoted definition. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2aae741bb30e3be3c64324cd6334778bd271a903
Gerrit-Change-Number: 42745
Gerrit-PatchSet: 9
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 04 Oct 2020 23:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment