Attention is currently required from: Michał Kopeć.
Hello Michał Kopeć,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74402
to look at the new patch set (#2).
Change subject: mb/msi/ms_7d25: Clear recovery request in mainboard_final ......................................................................
mb/msi/ms_7d25: Clear recovery request in mainboard_final
For ChromeOS platform the recovery reason is cleared in vb2api_kernel_phase2 which is probably not called by any non-ChromeOS system. It results in the platform being stuck in recovery mode, e.g. when RW firmware verification fails. Even if the RW partition is flashed with correctly signed image, the persistent non-zero recovery reason will prevent vboot from attempting the RW partition check.
Clear the recovery reason in the mainboard_final function. The call is made very late in the boot process thus it will not interfere with vboot logic. If still relevant, verstage will set the recovery reason back. The recovery reason will still be available in vboot workbuf in cbmem for the payload and OS. The additional reboot happening in the verstage when in recovery mode is a small disadvantage of this solution.
TEST=Boot with RW partition corrupted and then with RW partition valid. When it is corrupted, the platform stays in recovery mode, when becomes valid the platform boots from RW partition. Tested on MSI PRO Z690-A DDR4.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I6c5444c2976fe5f68a2c6964710761c268d2255b --- M src/mainboard/msi/ms7d25/mainboard.c 1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74402/2