Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32055 )
Change subject: lib/edid.c: Dump EDID breakdown after null check
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32055/1/src/lib/edid.c
File src/lib/edid.c:
https://review.coreboot.org/#/c/32055/1/src/lib/edid.c@1144
PS1, Line 1144: printk(BIOS_SPEW, "No EDID found\n");
That makes sense. We should also probably change the incorrect header message to an error too then. […]
Please update both in a follow-up commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fe3d911df3a11a873056d3a5c05c5a3cbcfe2c0
Gerrit-Change-Number: 32055
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Mar 2019 08:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment