[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Dump ME f/w version and status information.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )

Change subject: soc/intel/cannonlake: Dump ME f/w version and status information.
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c 
File src/soc/intel/cannonlake/me.c:

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c@168 
PS6, Line 168: (void)unused;
> I don't think this is required.

No not required, it's an old habit of mine for documentation purposes.

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c@248 
PS6, Line 248: (void)unused;
> Why?

See above.  I can remove these if you like.