Attention is currently required from: Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54914 )
Change subject: drivers/pc80/mc146818rtc: Check date and time for sanity
......................................................................
Patch Set 5:
(1 comment)
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54914/comment/4b428c2e_e2ee56e2
PS5, Line 62: bootblcok
This is needed for one of the google boards which uses rtc in bootblock, too.
Well, this line has a typo: `bootblcok`. It doesn't cause any errors per se because it's valid Makefile syntax, but it has no effect on the build process.
So, if Jenkins didn't fail, it means the google board you're referring to doesn't get build-tested with the configuration that needs this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54914
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bc600c78bab50c70372600347f63156df127012
Gerrit-Change-Number: 54914
Gerrit-PatchSet: 5
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 08:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment