Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46846 )
Change subject: mb/google/volteer: Enable SOC_INTEL_CSE_RW_UPDATE for qs variants
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46846/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/46846/5/src/mainboard/google/voltee...
PS5, Line 7: SOC_INTEL_CSE_RW_UPDATE
Thanks for comments. I moved SOC_INTEL_CSE_FW_UPDATE to config. […]
I think it's okay to have SOC_INTEL_CSE_LITE_SKU here because it does not have any external dependencies. The reason for moving SOC_INTEL_CSE_RW_UPDATE to config.${BOARD} is because of the update feature dependency on the CSE RW blob.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida67bfd022f4ef1031adbbb8361c8b84d20b92c8
Gerrit-Change-Number: 46846
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 03:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment