Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38214 )
Change subject: asus/am1i-a: fix the VGA-related PCI resource allocation problems
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG@11
PS3, Line 11: It does not bring any downsides if there is no discrete VGA adapter.
Please wrap the lines after 75 characters.
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG@15
PS3, Line 15: Otherwise there could be i.e. a "Fatal error during GPU init".
Maybe show the BARs reported by Linux (or coreboot) before and after.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84f72459753ae6631ab4b318b71ce89968a336ad
Gerrit-Change-Number: 38214
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elisenda
lists@e4l.es
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 13:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment