26 Apr
2023
26 Apr
'23
2 a.m.
Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Tony Huang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74776 )
Change subject: mb/google/nissa/var/yavilla: Add elan touchscreen support ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/yavilla/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74776/comment/4e81bbe2_40c1958b PS1, Line 168: register "stop_delay_ms" = "280"
It's for bring-up. Timing will be measured after device arrives. […]
suggest ask vendor for the IC spec for the timing. fine to me though.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2779c2930d89ff42233f9b20bd8abdf6dc00c0e0
Gerrit-Change-Number: 74776
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Attention: Tony Huang tony-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 09:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tony Huang tony-huang@quanta.corp-partner.google.com
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment