Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33657 )
Change subject: arch: Add missing #include <commonlib/helpers.h> ......................................................................
Patch Set 2:
I think it is expected that <commonlib/helpers.h> is chain-included from <stddef.h> (which in turn is expected to be chain-included from <types.h>). I think we had this discussion with <stdint.h> vs. <types.h> before as well... it's a bit of a matter of taste and it's not done consistently throughout coreboot, but in my opinion it's not really useful to always have to include every single of these common infrastructure headers separately. There's a reason they have chain includes. I find it nice when I can just include <types.h> and know that I have all these common "toolbox" macros available without having to chase down every single one.