Attention is currently required from: Lorenzo Aloe, Máté Kukri, Paul Menzel.
Michał Żygowski has posted comments on this change by Lorenzo Aloe. ( https://review.coreboot.org/c/coreboot/+/83473?usp=email )
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant ......................................................................
Patch Set 7:
(5 comments)
Patchset:
PS7: Overall looks good.
Commit Message:
https://review.coreboot.org/c/coreboot/+/83473/comment/ef1d2eb0_9cddc296?usp... : PS7, Line 7: src/mainboard/dell/snb_ivb_workstations/: Add variant
mb/dell/snb_ivb_workstations: Add SFF variant
mb/dell/snb_ivb_workstations: Add OptiPlex 9010 MT variant
https://review.coreboot.org/c/coreboot/+/83473/comment/77991fa9_0245d447?usp... : PS7, Line 9: T1650
Isn’t that a Precision.
Yes, it is. But as mentioned below in the commit message, boards are the same.
https://review.coreboot.org/c/coreboot/+/83473/comment/72325802_b0c89e3f?usp... : PS7, Line 11: The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
The diff only seems to change OptiPlex stuff?
Because it is an OptiPlex being added.
File src/mainboard/dell/snb_ivb_workstations/Kconfig:
https://review.coreboot.org/c/coreboot/+/83473/comment/f7b53162_89083f5f?usp... : PS7, Line 41: default "OptiPlex 7010/9010 MT" if BOARD_DELL_OPTIPLEX_9010_MT 7010 series will most likely need separate Kconfigs, because the subsystem IDs and SMBIOS will need to be different. The commit message says it adds 9010 MT and let's stick to it.