Attention is currently required from: Bora Guvendik, Julius Werner, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email )
Change subject: src/lib: Add Kconfig variable for fw_config default value ......................................................................
Patch Set 3:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/83153/comment/62de21f4_07823207?usp... : PS2, Line 548: 0x00000
I change default value to UNDEFINED_FW_CONFIG and this won't be used unless config. […]
Subrata, I assume you mean FW_CONFIG_SOURCE_CHROMEEC_CBI. Yes. we set this flag off in our build for Windows EC and also for simulation environment and intend not to use Chrome EC. In fw_config.h, it has this define:
#define UNDEFINED_FW_CONFIG ~((uint64_t)0) -> 0xffffffffffffffff
The same value is used for CONFIG_FW_CONFIG_DEFAULT_VALUE as default in Kconfig so that even all bits are '1', but then this flag is not provisioned. If not overridden in config.<board>, no code flow is changed.
In addition, in our standalone make build, we don't have project config.star like the one in cros environment. Also, during PO, we used Windows EC and also we had issue with Chrome EC and not able to get CBI command back then. This flag is used so that we can have at least fw_config value other than UNDEFINED_FW_CONFIG to move forward.