[coreboot-gerrit] Change in coreboot[master]: [WIP] arch/x86: Remove C_ENV_BOOTBLOCK_SIZE

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41695 )

Change subject: [WIP] arch/x86: Remove C_ENV_BOOTBLOCK_SIZE
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41695/2/src/southbridge/intel/i8237... 
File src/southbridge/intel/i82371eb/bootblock.c:

https://review.coreboot.org/c/coreboot/+/41695/2/src/southbridge/intel/i8237... 
PS2, Line 28:  */
> Isn't it better to create a solution for this before merging it? After all it can result in a (semi) […]

The bootblock on systems with i82371eb is currently just over 4 KiB, if it grows over 64 KiB some builds could fail. So we are currently very far away from reaching the limit and I did not immediately see a good place to place build-time asserts.