[coreboot-gerrit] Change in ...coreboot[master]: drivers/wifi: Add generic WiFi driver

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )

Change subject: drivers/wifi: Add generic WiFi driver
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c 
File src/drivers/wifi/generic.c:

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@195 
PS4, Line 195: )
> Was the check for !config->wake dropped intentionally?

See patchset #3.

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@230 
PS4, Line 230: const char *generic_wifi_acpi_name(const struct device *dev)
> That's an interesting thought. […]

I guess the worst thing that happens is ACPI interpreter throws more runtime errors in kernel logs or the choice of OS you have made gives you cryptic BSOD...

If duplicate name is ACPI violation, we should fix it here and now. Not my thing, ASL, so I don't know what relevance this has.