Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36028 )
Change subject: google/chromeos: Add a library to get DSM calibration data ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36028/7/src/include/dsm_calib.h File src/include/dsm_calib.h:
https://review.coreboot.org/c/coreboot/+/36028/7/src/include/dsm_calib.h@1 PS7, Line 1: /*
You could put this with the code in vendorcode/google/chromeos and include the header with the full […]
It can potentially be moved to chromeos.h under vendorcode/google/chromeos/ along with cbmem_add_vpd_calibration_data(): https://review.coreboot.org/cgit/coreboot.git/tree/src/vendorcode/google/chr...
https://review.coreboot.org/c/coreboot/+/36028/7/src/include/dsm_calib.h@22 PS7, Line 22: get_dsm_calibration_from_key Can you please add a comment indicating what the arguments are and what the expectations are e.g. key needs to start with dsm_calib, etc.
https://review.coreboot.org/c/coreboot/+/36028/7/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/dsm_calib.c:
https://review.coreboot.org/c/coreboot/+/36028/7/src/vendorcode/google/chrom... PS7, Line 28: char static