Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )
Change subject: src: Add '-Wduplicated-branches' warning option ......................................................................
Patch Set 23:
Patch Set 23:
Patch Set 22:
(1 comment)
Such warning options can produce a lot of noise, e.g. false positives. Unless there was a serious bug in the past that would have been discovered by this, I'd prefer _not_ to use this option.
The nvidia/tegra124 code (https://review.coreboot.org/c/coreboot/+/40430) looks like a real bug.
If the non-vendorcode code would build with that option, I believe it’s a good thing, as developers can often reorganize the code (helping other developers to understand it better).
This warning was added and not enabled because it results in too many false positives. And since we use -Werror, a false positive means a build failure. Refer to: https://patchwork.ozlabs.org/project/gcc/patch/20161019110707.GJ2576@redhat....
I don't want this option, as it can and will result in stuff like this: https://github.com/fmtlib/fmt/commit/bef89db6e7d10499a91affca7a933f264c7956d...