Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58052 )
Change subject: mb/siemens/mc_ehl: Move UART_FOR_CONSOLE switch to variant level ......................................................................
mb/siemens/mc_ehl: Move UART_FOR_CONSOLE switch to variant level
There are currently two variants for mc_ehl where different UARTs are used for the console. Move the Kconfig switch UART_FOR_CONSOLE to the Kconfig of the variant and select the matching value there.
Change-Id: I7152013a0e32ff151b92932a47953705e591dc0d Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/58052 Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/siemens/mc_ehl/Kconfig M src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig 3 files changed, 8 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Mario Scheithauer: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_ehl/Kconfig b/src/mainboard/siemens/mc_ehl/Kconfig index 8e5d95f..90881aa 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig +++ b/src/mainboard/siemens/mc_ehl/Kconfig @@ -34,9 +34,4 @@ config DIMM_SPD_SIZE default 512
-config UART_FOR_CONSOLE - int - default 2 if INTEL_LPSS_UART_FOR_CONSOLE - default 0 - endif # BOARD_SIEMENS_BASEBOARD_MC_EHL diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig index bc799dd..fbee7b0 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig @@ -8,4 +8,8 @@ config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_ehl.fmd"
+config UART_FOR_CONSOLE + int + default 2 + endif # BOARD_SIEMENS_MC_EHL1 diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig index 645379f..f577b24 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig @@ -8,4 +8,8 @@ config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_ehl.fmd"
+config UART_FOR_CONSOLE + int + default 0 + endif # BOARD_SIEMENS_MC_EHL2