[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Order the CPUs based on their APIC IDs

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72131 )

Change subject: soc/intel/common: Order the CPUs based on their APIC IDs
......................................................................

Patch Set 12:

(2 comments)

File src/soc/intel/common/block/acpi/cpu_hybrid.c:

https://review.coreboot.org/c/coreboot/+/72131/comment/300cdcfb_62a3d44f 
PS12, Line 28: 	int32_t apic_ids[CONFIG_MAX_CPUS];
> uint32_t

I don't think APIC ID numbering can go beyond 2,147,483,647, so this shouldn't be any issue!

I too agree there won't be any negative APIC number, but this might require type change for argument of bubblesort() API. If so, existing bubblesort() API can't be used for negative numbers.

https://review.coreboot.org/c/coreboot/+/72131/comment/28e40239_8f5002e8 
PS12, Line 31: 	uint8_t total_cpu_cnt;
> How does this work for >255 local APICs ?

This is still within total core count of Intel SOC for now. But, I can update it to uint16_t which can support higher CPU count(beyond 255).