build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41442 )
Change subject: device: Move resource allocation into a separate compilation unit ......................................................................
Patch Set 2:
(12 comments)
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... File src/device/resource_allocator_v3.c:
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 93: struct bus* link; "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 163: if ((base & 0x300) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 170: else if ((base >= 0x3b0) && (base <= 0x3df)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 259: if ((base & 0x300) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 266: else if ((base >= 0x3b0) && (base <= 0x3df)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 326: struct bus* link; "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 341: IOINDEX_LINK(child_bridge->index)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 380: struct constraints* limits) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 407: if (((res->base + res->size -1) < lim->base) need consistent spacing around '-' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 420: if ((signed long long)(lim->limit - (res->base + res->size -1)) need consistent spacing around '-' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 424: lim->limit = res->base -1; need consistent spacing around '-' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/41442/2/src/device/resource_allocat... PS2, Line 521: for (child = root->link_list->children; child; child=child->sibling) spaces required around that '=' (ctx:VxV)