Attention is currently required from: Paul Menzel, Julius Werner, Yu-Ping Wu.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: Update helper function to know size of memchipinfo
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63026/comment/ec687345_d26c68ba
PS5, Line 7: soc/qualcomm/common: update size of memchipinfo structure
hi julius updated commit message with details
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/63026/comment/a9b5d739_8a97cdc3
PS6, Line 8:
hi paul, […]
corrected commit message
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/667f3606_5f67797c
PS5, Line 30: uint64_t *
Fair enough... I thought blob_address was a void* already. […]
hi julius, updated type cast as (void *)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d59669adaf287d0eb7b58ccb0fe3f98e3d23281
Gerrit-Change-Number: 63026
Gerrit-PatchSet: 10
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 22:25:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ravi Kumar Bokka
rbokka@codeaurora.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment