Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49358 )
Change subject: build system: Structure and serialize INTERMEDIATE ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I'm not too keen on hunting down parallel executions every time somebody adds a rule and forget to a […]
Well, I don't think anybody should directly dd to CBFS images anyway so you shouldn't really the flock utility. cbfstool is the only thing that should touch CBFS sections, and if other stuff needs to be written to other sections they should be clearly defined in the FMAP and written with cbfstool write, not just by juggling raw offsets in dd. I just didn't want to figure out how to rewrite all the old platforms but I don't think we should let new platforms do that anymore.
Anyway, I don't really mind if you want to serialize this anyway, this option seems a lot nicer than Martin's patch. If you do you might as well take the explicit flock calls in those rules back out again.
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49358/comment/d06b76ba_9494d879 PS2, Line 1151: Why not add $(obj)/coreboot.pre right here so you don't have to do it explicitly everywhere? Modifying that file is the only point of these rules.