Attention is currently required from: Jason Glenesk, Raul Rangel, ritul guru, Marshall Dawson, Name of user not set #1004133, Al Hirani, Rob Barnes, Fred Reitberger.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61462 )
Change subject: soc/amd/common/block/psp: add PSP command
......................................................................
Patch Set 12:
(1 comment)
File src/soc/amd/common/block/psp/psp_def.h:
https://review.coreboot.org/c/coreboot/+/61462/comment/1515da0c_dabe77ad
PS5, Line 29: CORE_2_PSP_MSG_38_OFFSET
can we have more descriptive name PSB_HSTI_STATUS_OFFSET?
I left it as MSG_38 because i wanted to segregate the SPL functionality from the MSFT HSTI feature, which might not be so relevant here in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0575356a7c6172e2e0f2eaf9d1a6706468fe92d
Gerrit-Change-Number: 61462
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mohan Viswanathan
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Name of user not set #1004133
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Name of user not set #1004133
Gerrit-Attention: Al Hirani
al.hirani13@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 22:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ritul guru
ritul.bits@gmail.com
Gerrit-MessageType: comment