Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83987?usp=email )
Change subject: soc/mediatek/common: Print error if GPIO raw_id is not in the range ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83987/comment/e72f1126_8d320c52?usp... : PS1, Line 7: soc/mediatek: Add null check for info with error handling
soc/mediatek/common: Print error if GPIO raw_id is not in the range
Done
File src/soc/mediatek/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/83987/comment/62c394d7_97401b56?usp... : PS1, Line 193: printk(BIOS_ERR, "Error: raw_id is out of range\n");
Alternatively, the error could be printed in `get_gpio_driving_info()`?
Please refer to: https://review.coreboot.org/c/coreboot/+/83922/comment/cfeaa4cf_0ea805e7/
https://review.coreboot.org/c/coreboot/+/83987/comment/dee6f6bc_f14f8d11?usp... : PS1, Line 193: "Error: raw_id is out of range\n");
`Error` is covered by `BIOS_ERR`. […]
Done
https://review.coreboot.org/c/coreboot/+/83987/comment/96efbecd_e9bb2f6d?usp... : PS1, Line 193: printk(BIOS_ERR, "Error: raw_id is out of range\n");
Include the GPIO id?
Done