[coreboot-gerrit] [XS] Change in coreboot[main]: intel/cmm/block: use CONFIG_SMM_TSEG_SIZE in sa_get_tseg_size function

[Wonkyu Kim (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Jérémy Compostella, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik.

Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84210?usp=email )

Change subject: intel/cmm/block: use CONFIG_SMM_TSEG_SIZE in sa_get_tseg_size function
......................................................................

Patch Set 4:

(2 comments)

File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/84210/comment/1ae7191e_7179d1a8?usp... :
PS2, Line 155: 	return sa_get_gsm_base() - sa_get_tseg_base();
> > FSP team mentioned that Tseg size is passed by UPD and memory map(relationship for  Tesg base and  […]

That's correct. current issue is due to GSM base is not programmed if IGD is not enabled.  Let me use condition to check GSM base address as memory map(calculation method is not changed yet but it can be changed with using high mmio in future silicon). If calculation method is changed later, let's update it with new Kconfig later.

Only thing we need to use sa_get_gsm_base as condition as sa_get_gsm_size is not available in systemagent_early.c

So, it'll be like below.

if (sa_get_gsm_base() == 0)
   return CONFIG_SMM_TSEG_SIZE;
else
   return sa_get_gsm_base() - sa_get_tseg_base();

File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/84210/comment/a157d5a9_9e05e3fc?usp... :
PS3, Line 151: 	if (CONFIG_SMM_TSEG_SIZE) {
             : 		return CONFIG_SMM_TSEG_SIZE;
             : 	}
             :
> > If CONFIG_SMM_TSEG_SIZE is defined use CONFIG_SMM_TSEG_SIZE rather than calculation. […]

I comments in other comments' reply.